Favor expect.not.toHaveBeenCalled.

Change-Id: I7009ff69bfca5ef8a38bcdff73a16a02cfa205b1
Pavelas · Jun 26, 2019 · b235ca4 · b235ca4
1 parent e2ba179
commit b235ca4
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 3 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -216,6 +216,12 @@ module.exports = {
                         '[callee.object.property.name=calls]',
             'message': 'Use expect.toHaveBeenCalledTimes',
           },
+          {
+            'selector':
+                'CallExpression[callee.property.name=toHaveBeenCalledTimes] >' +
+                'Literal[value=0]',
+            'message': 'Use expect.not.toHaveBeenCalled',
+          },
           ...commonNoRestrictedSyntax,
         ],
       },

diff --git a/test/dash/dash_parser_live_unit.js b/test/dash/dash_parser_live_unit.js
@@ -368,7 +368,7 @@ describe('DashParser Live', () => {
 
     expect(manifest.periods.length).toBe(1);
     // Should call filterAllPeriods for parsing the first manifest
-    expect(filterNewPeriod).toHaveBeenCalledTimes(0);
+    expect(filterNewPeriod).not.toHaveBeenCalled();
     expect(filterAllPeriods).toHaveBeenCalledTimes(1);
 
     fakeNetEngine.setResponseText('dummy://foo', secondManifest);

diff --git a/test/media/region_timeline_unit.js b/test/media/region_timeline_unit.js
@@ -44,7 +44,7 @@ describe('RegionTimeline', () => {
     const differentEndTime = createRegion('my-region', 0, 5);
 
     // Make sure we are starting from a blank slate.
-    expect(onNewRegion).toHaveBeenCalledTimes(0);
+    expect(onNewRegion).not.toHaveBeenCalled();
 
     // When we add a region, we should get an event.
     timeline.addRegion(initialRegion);

diff --git a/test/media/streaming_engine_unit.js b/test/media/streaming_engine_unit.js
@@ -2077,7 +2077,7 @@ describe('StreamingEngine', () => {
       runTest();
       expect(onError).toHaveBeenCalledTimes(1);
       expect(netEngine.attempts).toBe(1);
-      expect(mediaSourceEngine.endOfStream).toHaveBeenCalledTimes(0);
+      expect(mediaSourceEngine.endOfStream).not.toHaveBeenCalled();
     });
 
     it('does not invoke the callback if the error is handled', () => {