style: Re-enable the prefer-spread eslint rule

The prefer-spread rule to prevent use of apply() was disabled, but we
had another custom rule that also prevented the use of apply().  This
re-enables the standard rule.

Issue shaka-project#2639

Change-Id: Ic3778d7267deb6cd5ed49282ea43bb84ad076060

.eslintrc.js

@@ -29,8 +29,9 @@ const commonNoRestrictedSyntax = [
     'message': 'Use for-of instead of forEach',
   },
   {
-    'selector': 'CallExpression[callee.property.name=/^(bind|call|apply)$/]',
-    'message': 'Don\'t use Function bind/call/apply.',
+    // NOTE: prefer-spread rule covers .apply() already.
+    'selector': 'CallExpression[callee.property.name=/^(bind|call)$/]',
+    'message': 'Don\'t use Function bind/call.',
   },
   {
     'selector': 'MemberExpression[property.name="prototype"]',
@@ -79,7 +80,6 @@ module.exports = {
 
     // Temporary Google style overrides while we get in compliance with the
     // latest style guide {{{
-    'prefer-spread': 'off',
     'require-jsdoc': 'off',
     // }}}
 

lib/cast/cast_receiver.js

@@ -656,7 +656,7 @@ shaka.cast.CastReceiver = class extends shaka.util.FakeEventTarget {
         const methodName = message['methodName'];
         const args = message['args'];
         const target = this.targets_[targetName];
-        // eslint-disable-next-line no-restricted-syntax
+        // eslint-disable-next-line prefer-spread
         target[methodName].apply(target, args);
         break;
       }
@@ -672,7 +672,7 @@ shaka.cast.CastReceiver = class extends shaka.util.FakeEventTarget {
         const id = message['id'];
         const senderId = event.senderId;
         const target = this.targets_[targetName];
-        // eslint-disable-next-line no-restricted-syntax
+        // eslint-disable-next-line prefer-spread
         let p = target[methodName].apply(target, args);
         if (targetName == 'player' && methodName == 'load') {
           // Wait until the manifest has actually loaded to send another media

test/player_integration.js

@@ -624,7 +624,7 @@ describe('Player', () => {
           if (arguments.length > 2000) {
             throw new RangeError('Synthetic Range Error');
           }
-          // eslint-disable-next-line no-restricted-syntax
+          // eslint-disable-next-line prefer-spread
           return oldFromCharCode.apply(null, arguments);
         };
         await player.load('/base/test/test/assets/large_file.mpd');