Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate worksheet name using Libxlsxwriter #83

Merged

Conversation

datbth
Copy link
Contributor

@datbth datbth commented Mar 23, 2022

Summary

Validate worksheet name using Libxlsxwriter.workbook_validate_sheet_name.

Description

  • Before:

    • Core worksheet name validation is done within Libxlsxwriter and errors are logged as warnings only
    • This causes Worksheet#write_value to crash with segmentation fault error
    • Example
      image
  • After:

    • Validate worksheet name using WorkbookWrappers#validate_worksheet_name

Other changes

Notes

  1. It appears to me that intentional null pointers are not being carefully handled at the moment. For example, usage on WorkbookWrappers#get_worksheet_by_name when the worksheet is not found will also face the same issue. Revise NULL pointers that are returned intentionally? #84

@Paxa Paxa merged commit 88e1138 into Paxa:master Mar 24, 2022
@Paxa
Copy link
Owner

Paxa commented Mar 24, 2022

Thank you

@datbth datbth deleted the validate-worksheet-name-using-libxlsxwriter branch March 24, 2022 15:45
@Paxa
Copy link
Owner

Paxa commented Jan 12, 2023

Published version 0.4.1, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

workbook_validate_worksheet_name renamed to workbook_validate_sheet_name
3 participants