Update djangorestframework dependency #76
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current version constraint for the
djangorestframework
dependency in thepayme-pkg
package is too specific and may cause compatibility issues for projects requiring different versions ofdjangorestframework
.To address this, I've updated the
requirements.txt
file to use a broader version constraint:djangorestframework>=3.14.0,<3.16.0
This change should allow the
payme-pkg
package to work withdjangorestframework
version 3.14.0 and higher, including newer versions like the one required by my project (^3.15.1
), while maintaining compatibility for existing users.Additionally, it might be beneficial to consider the following improvements:
Make the
djangorestframework
dependency version configurable: Introduce a configuration option or setting that allows users to specify the desired version ofdjangorestframework
based on their project requirements.Use environment variables for dependency versions: Implement support for setting the required
djangorestframework
version using environment variables. This would provide more flexibility for users with different project requirements and deployment environments.Improve dependency management: Explore more robust dependency management solutions, such as using a tool like Poetry or pipenv, which can handle dependency resolution and versioning more effectively.
I've tested the updated package locally with the broader
djangorestframework
dependency constraint, and it seems to work correctly. However, thorough testing across different project configurations anddjangorestframework
versions would be recommended before merging these changes.Please review the proposed changes and let me know if you have any concerns or suggestions for further improvements.