Rename threads to better aid with debugging #424
Conversation
|
|
||
|
|
||
|
|
||
| void RenameThread(const char* name); |
|
Tested and working as expected! LGTM! 👍 |
|
You seem to be missing a few? |
|
@MitchellCash so I did lol, also the names were a bit inconsistent I thought I went through them already. Fixed both. (15 minutes) |
|
More: void ThreadRPCServer(void* parg)void ipcThread(void* parg) |
| @@ -421,6 +421,9 @@ bool GetMyExternalIP(CNetAddr& ipRet) | |||
|
|
|||
| void ThreadGetMyExternalIP(void* parg) | |||
| { | |||
| // Make this thread recognisable as the message handling thread | |||
There was a problem hiding this comment.
This thread is not the message handling thread.
// Make this thread recognisable as the external IP detection thread
There was a problem hiding this comment.
fixed, and the other missing ones (10 minutes)
or not, been playing with Golang and forgot some semi-colons. Travis is going to crash lol.
|
If you squash those commits down it looks good to me now. Confirmed with |
|
#434 introduces a new thread. Following testing of it should we rebase this pull over the top to include the new |
|
@MitchellCash probably yes. |
|
rebased over master to accommodate 20bc095 (5 minutes) |
No description provided.