Allow RPC clearorphans command to properly clear orphans in a QT wallet

src/qt/bitcoin.cpp

@@ -132,6 +132,16 @@ static void handleRunawayException(std::exception *e)
     exit(1);
 }
 
+/* Allow RPC clear orphans to work properly in QT as well
+ */
+void QTClearOrphans()
+{
+    /* This is actually stored in bitcoingui.cpp because otherwise we have to
+     * instantiate multiple TransactionView classes which we really don't want
+     * to do (for obvious reasons). */
+    GUIClearOrphans();
+}
+
 #ifndef BITCOIN_QT_TEST
 int main(int argc, char *argv[])
 {

src/qt/bitcoingui.cpp

@@ -60,6 +60,9 @@
 
 #include <iostream>
 
+// Global pointer to TransactionView so that we can clear orphans from RPC
+static TransactionView *transactionview;
+
 BitcoinGUI::BitcoinGUI(QWidget *parent):
     QMainWindow(parent),
     clientModel(0),
@@ -102,6 +105,8 @@ BitcoinGUI::BitcoinGUI(QWidget *parent):
     transactionsPage = new QWidget(this);
     QVBoxLayout *vbox = new QVBoxLayout();
     transactionView = new TransactionView(this);
+    // Set our global pointer for RPC clear orphans support.
+    transactionview = transactionView;
     vbox->addWidget(transactionView);
     transactionsPage->setLayout(vbox);
 
@@ -963,3 +968,7 @@ void BitcoinGUI::editConfig()
     mb.exec();
     QDesktopServices::openUrl(QUrl::fromLocalFile(QString::fromStdString(GetConfigFile().string())));
 }
+
+void GUIClearOrphans() {
+    QMetaObject::invokeMethod(transactionview, "clearOrphans", Qt::QueuedConnection);
+}

src/qt/bitcoingui.h

@@ -189,4 +189,6 @@ private slots:
     void editConfig();
 };
 
+void GUIClearOrphans();
+
 #endif // BITCOINGUI_H

src/rpcwallet.cpp

@@ -9,6 +9,7 @@
 #include "bitcoinrpc.h"
 #include "kernelrecord.h"
 #include "primenodes.h"
+#include "ui_interface.h"
 #include "wallet.h"
 #include "walletdb.h"
 
@@ -1786,8 +1787,11 @@ Value clearorphans(const Array& params, bool fHelp)
             "clearorphans\n"
             "Clears orphaned transactions from the wallet file.");
 
+#ifdef QT_GUI
+    QTClearOrphans();
+#else
     pwalletMain->ClearOrphans();
-
+#endif
     return true;
 }
 

src/ui_interface.h

@@ -47,4 +47,7 @@ extern void QueueShutdown();
 extern void InitMessage(const std::string &message);
 extern std::string _(const char* psz);
 
+/* This only exists here and not in noui.cpp as otherwise bitcoinrpc.cpp calls  ClearOrphans directly in wallet.cpp */
+extern void QTClearOrphans();
+
 #endif