GH-#70: Add PR template requiring mobile and desktop screenshots #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ile-screenshots PecanProjectGH-70: Add PR template for mobile/desktop screenshots
dlebauer
approved these changes
Feb 18, 2025
|
thanks @dlebauer , This was my first contribution in pecan |
|
missed this , thanks for taking care of the PR @dlebauer 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #70
Description
Problem
Currently, contributors only include screenshots for large screens when making style changes or introducing new components. This often leads to visual bugs on small screens (e.g., mobile devices), breaking the UI while fixing other issues.
Solution
This PR adds a Pull Request template that requires contributors to include screenshots for both desktop and mobile views when making UI changes. The template also provides instructions on how to test responsiveness using browser developer tools.
Changes
.github/pull_request_template.mdwith: