Merge pull request #3261 from meetagrawal09/fix-checks

Fixing Notes in `PEcAn.workflow`
PecanProject · Feb 18, 2024 · 5b9778b · 5b9778b
2 parents 0fd1bb4 + 089f2c7
commit 5b9778b
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 17 deletions.
diff --git a/base/workflow/DESCRIPTION b/base/workflow/DESCRIPTION
@@ -1,7 +1,7 @@
 Package: PEcAn.workflow
 Type: Package
-Title: PEcAn functions used for ecological forecasts and
-    reanalysis
+Title: PEcAn Functions Used for Ecological Forecasts and
+    Reanalysis
 Version: 1.7.2
 Date: 2021-10-04
 Authors@R: c(person("Mike", "Dietze", role = c("aut"),

diff --git a/base/workflow/R/run.write.configs.R b/base/workflow/R/run.write.configs.R
@@ -91,7 +91,7 @@ run.write.configs <- function(settings, write = TRUE, ens.sample.method = "unifo
     ensemble.samples <- samples$ensemble.samples
     sa.samples <- samples$sa.samples
     runs.samples <- samples$runs.samples
-    env.samples <- samples$env.samples
+    ## env.samples <- samples$env.samples
   } else {
     PEcAn.logger::logger.error(samples.file, "not found, this file is required by the run.write.configs function")
   }

diff --git a/base/workflow/tests/Rcheck_reference.log b/base/workflow/tests/Rcheck_reference.log
@@ -48,11 +48,6 @@ Strong dependencies not in mainstream repositories:
   PEcAn.data.atmosphere, PEcAn.data.land, PEcAn.DB, PEcAn.logger,
     PEcAn.remote, PEcAn.settings, PEcAn.uncertainty, PEcAn.utils
 
-The Title field should be in title case. Current version is:
-‘PEcAn functions used for ecological forecasts and reanalysis’
-In title case that is:
-‘PEcAn Functions Used for Ecological Forecasts and Reanalysis’
-
 The Date field is over a month old.
 * checking package namespace information ... OK
 * checking package dependencies ... OK
@@ -93,14 +88,7 @@ Maintainer field differs from that derived from Authors@R
 * checking S3 generic/method consistency ... OK
 * checking replacement functions ... OK
 * checking foreign function calls ... OK
-* checking R code for possible problems ... NOTE
-run.write.configs: no visible binding for global variable
-  ‘trait.samples’
-run.write.configs: no visible binding for global variable ‘sa.samples’
-run.write.configs: no visible binding for global variable
-  ‘ensemble.samples’
-Undefined global functions or variables:
-  ensemble.samples sa.samples trait.samples
+* checking R code for possible problems ... OK
 * checking Rd files ... OK
 * checking Rd metadata ... OK
 * checking Rd line widths ... OK
@@ -119,4 +107,4 @@ Undefined global functions or variables:
 * checking for detritus in the temp directory ... OK
 * DONE
 
-Status: 1 WARNING, 2 NOTEs
+Status: 1 WARNING, 1 NOTEs