Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FATES/CLM param R files [WIP] #2304

Draft
wants to merge 5 commits into
base: ctsm_package
Choose a base branch
from

Conversation

bailsofhay
Copy link
Collaborator

These are the 2 R parameter files to run CLM or fates for PEcAn.

Description

I changed Shawns original write_params-clm.R file so that there are 2 files: 1) is write_params-clm.R, which only deals with CLM parameter variables, and 2) write_params-fates.R, which only deals with FATES parameter variables. Both R files use the same general parameter variable name for consistency, but call the specific model parameter name. e.g. Ratio of new fine root : new leaf carbon allocations is "froot_leaf", while the specific clm and fates variable name is froot_leaf and fates_allom_l2fr, respectively.

Motivation and Context

We're trying to get the CLM coupled with PEcAn!!!!

There needs to be discussion about additional variables/parameters that we would like to add to these scripts for future CLM/FATES work, but for now these are the most important variables as stated in : https://docs.google.com/document/d/12XWb7DmmOuvRAOEDviBt-x2uCUWIRDASZA2T9u_fbY0/edit#

Review Time Estimate

  • Immediately
  • Within one week
  • When possible

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the CHANGELOG.md.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@bailsofhay bailsofhay changed the title FATES/CLM param R files FATES/CLM param R files [WIP] Feb 28, 2019
@github-actions
Copy link

github-actions bot commented Apr 8, 2020

This PR is stale because it has been open 365 days with no activity.

@robkooper robkooper marked this pull request as draft September 9, 2020 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants