Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test suites for met2Cf.csv.R #3301

Merged
merged 30 commits into from
Jun 5, 2024
Merged

Add test suites for met2Cf.csv.R #3301

merged 30 commits into from
Jun 5, 2024

Conversation

Sweetdevil144
Copy link
Contributor

Description

This PR introduces the now-Updated test.met2CF.csv.R. Following changes were made:

  • Format parameters were Updated as they were long outdated with time.
  • Added a test suite to check if successful conversion takes place.

Motivation and Context

Fixes #202

Screenshot 2024-05-31 at 1 21 07 PM

Review Time Estimate

  • Immediately
  • Within one week
  • When possible

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • My name is in the list of CITATION.cff
  • I have updated the CHANGELOG.md.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Sweetdevil144 and others added 18 commits May 7, 2024 15:47
@Sweetdevil144
Update test.met2CF.csv.R
2ce9f80
@Sweetdevil144
Merge branch 'develop' of https://github.com/Sweetdevil144/pecan into…
3d158c8 
… develop
@Sweetdevil144
Merge branch 'PecanProject:develop' into develop
62ec135
@Sweetdevil144
Merge branch 'develop' of https://github.com/Sweetdevil144/pecan into…
bf27687 
… develop
@Sweetdevil144
Update datetime in test.met2CF.csv.R
508aabc
@Sweetdevil144
Merge branch 'PecanProject:develop' into develop
15f9408
@Sweetdevil144
Merge branch 'PecanProject:develop' into develop
f03eff1
@Sweetdevil144
Merge branch 'PecanProject:develop' into develop
55ca543
@Sweetdevil144
Merge branch 'PecanProject:develop' into develop
0e8f6cf
@Sweetdevil144
Update datetime to use lubridate
0268b04
@Sweetdevil144
Merge branch 'PecanProject:develop' into develop
9873b97
@Sweetdevil144
Refactor csv import format in test.met2CF.csv.R for debugging
2298a9b
@Sweetdevil144
Refactor 'format' in test.met2CF.csv.R for debugging
c59a3f2
@Sweetdevil144
Merge branch 'PecanProject:develop' into develop
b130f66
@Sweetdevil144
Format Specified correctly. Initial suites prepared
1466683
@Sweetdevil144
Finalized Initial Test suite
eadb6ab
@Sweetdevil144
Update lat lon
7411603
@Sweetdevil144
Update File comments
efbcba4
@mdietze
Copy link
Member

mdietze commented May 31, 2024

looks good to me but leaving final 👍 to @infotroph or @moki1202

@Sweetdevil144 Sweetdevil144 requested a review from infotroph June 2, 2024 04:06
@Sweetdevil144 Sweetdevil144 requested a review from infotroph June 5, 2024 08:31
@Sweetdevil144 Sweetdevil144 requested a review from infotroph June 5, 2024 18:47
@infotroph infotroph enabled auto-merge June 5, 2024 19:54
@infotroph infotroph added this pull request to the merge queue Jun 5, 2024
Merged via the queue into PecanProject:develop with commit b842bc1 Jun 5, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allgandalf allgandalf allgandalf left review comments

@infotroph infotroph infotroph approved these changes

Assignees

@infotroph infotroph

Labels
Modules Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix met2CF.csv tests
4 participants
@Sweetdevil144 @mdietze @infotroph @allgandalf