Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed possible arg discrepancy #3318

Merged
merged 9 commits into from
Jul 9, 2024

Conversation

Snafkin547
Copy link
Contributor

@Snafkin547 Snafkin547 commented Jun 26, 2024

Description

This PR aims to fix a potential discrepancy in one of the arguments in resampling soil grids.

Motivation and Context

In the previous resampling caused discrepancy in extent of soil grids because it matched NA_WorldClim to NA_SoilGrids, whilst the intended operation was to match NA_SoilGrids to NA_WorldClim.

Review Time Estimate

  • Immediately
  • Within one week
  • When possible

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • My name is in the list of CITATION.cff
  • I have updated the CHANGELOG.md.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mdietze mdietze enabled auto-merge July 8, 2024 23:51
@mdietze mdietze added this pull request to the merge queue Jul 9, 2024
Merged via the queue into PecanProject:develop with commit 4dfee93 Jul 9, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants