Update NASA DAAC download function to include all DAAC server. #3332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdietze
requested changes
Jul 12, 2024
| doi, | ||
| netrc_file = NULL, | ||
| just_path = FALSE) { | ||
| # if there is no credential file in the outdir. | ||
| # we will create a new one. | ||
| # this function is located within the GEDI_AGB_prep script. | ||
| if (length(list.files(outdir, pattern = "netrc")) == 0) { | ||
| netrc_file <- getnetrc(outdir) | ||
| if (is.null(outdir) & !just_path) { |
There was a problem hiding this comment.
I suspect a better default for outdir is the current directory (e.g. getwd() or "."). It's unexpected to provide a default value and then have that default value throw an error, as that means the argument is required and shouldn't have a default.
mdietze
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Review Time Estimate
Types of changes
Checklist: