-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Browndog #3348
Remove Browndog #3348
Conversation
Signed-off-by: Abhinav Pandey <[email protected]>
Signed-off-by: Abhinav Pandey <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Can you please
- add this change to the PEcAn.DB
NEWS.md
file in addition to CHANGELOG? - update all existing calls to
convert_input
to remove thebrowndog
arg?
Co-authored-by: Chris Black <[email protected]>
Co-authored-by: Chris Black <[email protected]>
Signed-off-by: Abhinav Pandey <[email protected]>
Signed-off-by: Abhinav Pandey <[email protected]>
Signed-off-by: Abhinav Pandey <[email protected]>
Signed-off-by: Abhinav Pandey <[email protected]>
Signed-off-by: Abhinav Pandey <[email protected]>
Removed other instances of Browndog from `*.Rmd` and addSecrets.R Signed-off-by: Abhinav Pandey <[email protected]>
Signed-off-by: Abhinav Pandey <[email protected]>
Let's also remove:
And not edit:
|
Signed-off-by: Abhinav Pandey <[email protected]>
Signed-off-by: Abhinav Pandey <[email protected]>
Signed-off-by: Abhinav Pandey <[email protected]>
#To Do: call to DAP to see if conversion to csv is possible | ||
#Brown Dog API call through BDFiddle, requires username and password | ||
key <- BrownDog::get_key("https://bd-api.ncsa.illinois.edu",username,password) | ||
token <- BrownDog::get_token("https://bd-api.ncsa.illinois.edu",key) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the last remaining step here is to remove BrownDog
from the benchmark package's DESCRIPTION file, then run ./scripts/generate_dependencies.R
to update the Docker dependency list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Sweetdevil144 Reminder that this PR needs one more (hopefully quick) change before it's ready to merge.
@Sweetdevil144 It looks like your commit of the final dependency update got pushed to #3324 instead of here. To fix, please:
Don't worry about removing commit 0ac5b39 from #3324 -- we'll merge this PR first and it'll become a no-change there. |
Signed-off-by: Abhinav Pandey <[email protected]>
Signed-off-by: Abhinav Pandey <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
Description
TODO : Remove Browndog support from all instances
Motivation and Context
Review Time Estimate
Types of changes
Checklist: