fixes for new check errors in R >= 4.4.0 (modules edition) #3350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
infotroph
commented
Jul 31, 2024
| Description: This package contains functions for performing forward runs and | ||
| inversions of radiative transfer models (RTMs). Inversions can be performed | ||
| using maximum likelihood, or more complex hierarchical Bayesian methods. | ||
| Underlying numerical analyses are optimized for speed using Fortran code. | ||
| Depends: R (>= 2.10) |
There was a problem hiding this comment.
R adds this automatically because some of the example data are not readable in older versions. I dunno, does depending on R newer than 2.1 force people to live too much on the cutting edge? 😁
infotroph
commented
Jul 31, 2024
| @@ -35,12 +35,12 @@ | |||
| #' Assign values to spectra by wavelength | |||
| #' | |||
| #' @inheritParams [[.spectra | |||
| #' @param values Vector or matrix of values to assign | |||
| #' @param value Vector or matrix of values to assign | |||
There was a problem hiding this comment.
the RHS argument to a [[ method always has to be named value
infotroph
commented
Jul 31, 2024
| raw.sensor.data.RData 109Kb 80Kb xz | ||
| sensor.rsr.RData 2.3Mb 1.9Mb xz | ||
| testspec.RData 1.2Mb 956Kb xz | ||
| * checking data for ASCII and uncompressed saves ... OK |
There was a problem hiding this comment.
I resaved these files as directed
mdietze
approved these changes
Sep 4, 2024
| Maintainer: ‘David LeBauer <[email protected]>’ | ||
| Authors@R: ‘David LeBauer <[email protected]>’ | ||
|
|
||
| License stub is invalid DCF. |
There was a problem hiding this comment.
Will these go away when we switch licenses?
There was a problem hiding this comment.
Yes, they will, at which point we'll be able to come back and remove them from this file (and having here until then won't hurt anything)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Continuing the check message cleanup from #3346 -- see there for more context.
Focusing here on the rest of the
modules/directory, mostly with Roxygen fixes.Motivation and Context
Review Time Estimate
Types of changes
Checklist: