-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes for new check errors in R >= 4.4.0 (modules edition) #3350
fixes for new check errors in R >= 4.4.0 (modules edition) #3350
Conversation
Description: This package contains functions for performing forward runs and | ||
inversions of radiative transfer models (RTMs). Inversions can be performed | ||
using maximum likelihood, or more complex hierarchical Bayesian methods. | ||
Underlying numerical analyses are optimized for speed using Fortran code. | ||
Depends: R (>= 2.10) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
R adds this automatically because some of the example data are not readable in older versions. I dunno, does depending on R newer than 2.1 force people to live too much on the cutting edge? 😁
@@ -35,12 +35,12 @@ | |||
#' Assign values to spectra by wavelength | |||
#' | |||
#' @inheritParams [[.spectra | |||
#' @param values Vector or matrix of values to assign | |||
#' @param value Vector or matrix of values to assign |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the RHS argument to a [[
method always has to be named value
raw.sensor.data.RData 109Kb 80Kb xz | ||
sensor.rsr.RData 2.3Mb 1.9Mb xz | ||
testspec.RData 1.2Mb 956Kb xz | ||
* checking data for ASCII and uncompressed saves ... OK |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I resaved these files as directed
Maintainer: ‘David LeBauer <[email protected]>’ | ||
Authors@R: ‘David LeBauer <[email protected]>’ | ||
|
||
License stub is invalid DCF. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will these go away when we switch licenses?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, they will, at which point we'll be able to come back and remove them from this file (and having here until then won't hurt anything)
Description
Continuing the check message cleanup from #3346 -- see there for more context.
Focusing here on the rest of the
modules/
directory, mostly with Roxygen fixes.Motivation and Context
Review Time Estimate
Types of changes
Checklist: