Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move compile time flags #24

Merged
merged 2 commits into from
Jan 31, 2025
Merged

Move compile time flags #24

merged 2 commits into from
Jan 31, 2025

Conversation

Alomir
Copy link
Collaborator

@Alomir Alomir commented Jan 15, 2025

This PR moves two compile switches from sipnet.c to the new modelStructures.h file. No tests have been added for that functionality, but this should be done at some later date.

Also, it adds a script that can be run to update version of modelStructures.h in the unit test directories whenever changes are made to the "production" version. This script was run and the updated test version is in this PR.

Copy link
Member

@infotroph infotroph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks! Extra points for managing to make a 3-language PR look easy.

# Print the line as-is if no overwrite is needed
print $0;
}
EOF
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the most cleanly formatted and readable awk script I have ever seen. 💯

@Alomir Alomir merged commit c0ca273 into master Jan 31, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants