Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

document and combine calclighteff functions #35

Merged
merged 4 commits into from
Mar 4, 2025
Merged

document and combine calclighteff functions #35

merged 4 commits into from
Mar 4, 2025

Conversation

dlebauer
Copy link
Member

@dlebauer dlebauer commented Feb 26, 2025 •
edited
Loading

we have to start somewhere!

  • Documented calclighteff fn
  • removed unused calcLightEff2 function
  • renamed calcLightEff3 --> calcLightEff (there is no calcLightEff1)

@dlebauer
document calclighteff functions
6698e48 
we have to start somewhere!
Alomir
Alomir reviewed Feb 28, 2025
View reviewed changes
Alomir
Alomir reviewed Feb 28, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 3, 2025

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-format (v19.1.1) reports: 1 file(s) not formatted
  • sipnet.c

Have any feedback or feature suggestions? Share it here.

@dlebauer dlebauer changed the title document calclighteff functions document and combine calclighteff functions Mar 3, 2025
Alomir
Alomir approved these changes Mar 3, 2025
View reviewed changes
Copy link
Collaborator

@Alomir Alomir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dlebauer dlebauer merged commit ba190da into master Mar 4, 2025
6 of 7 checks passed
@dlebauer dlebauer deleted the calclighteff_docs branch March 4, 2025 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alomir Alomir Alomir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dlebauer @Alomir