Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Automate SIPNET binary builds and manual release #36

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

AritraDey-Dev
Copy link

This pull request fixes #27

CI Workflow Enhancements:

  • .github/workflows/ci.yml: Added a step to upload SIPNET binaries after the build step.
  • .github/workflows/ci.yml: Introduced a new job to create a release, which includes checking out the code, creating a release, and uploading the release asset.

Makefile Updates:

  • Makefile: Added a release target to the all target dependencies.
  • Makefile: Defined the release target to package and compress the SIPNET binary and clean up the release directory.

Copy link
Collaborator

@Alomir Alomir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AritraDey-Dev Thank you for the PR!

Do I read this correctly, that it will create a release and upload binaries on every PR push? That would be way to often; at most, it should be on merging with the master branch.

Copy link
Member

@dlebauer dlebauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for taking this on @AritraDey-Dev

Two requests (with what I think the code would look like):

  1. trigger on tags matching vX.Y.Z
on:
  push:
    tags:
      - 'v*.*.*'
  1. create release as a draft
steps:
  ...
  with:
    ...
    draft: true

@AritraDey-Dev
Copy link
Author

AritraDey-Dev commented Mar 6, 2025

@dlebauer Thanks for the reviewing the PR.I will make those changes.

@AritraDey-Dev
Copy link
Author

@AritraDey-Dev Thank you for the PR!

Do I read this correctly, that it will create a release and upload binaries on every PR push? That would be way to often; at most, it should be on merging with the master branch.

Yes, you're correct. The current setup would trigger a release on every PR push. We should modify it to only create a release and upload binaries upon merging into the master branch. Thank you for pointing that out!

@AritraDey-Dev AritraDey-Dev requested review from dlebauer and Alomir March 6, 2025 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automate SIPNET Binary Builds & Manual Release
3 participants