-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an example that returns a sum of values. #94
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It helped a lot.
Codecov Report
@@ Coverage Diff @@
## master #94 +/- ##
=======================================
Coverage 93.68% 93.68%
=======================================
Files 1 1
Lines 190 190
=======================================
Hits 178 178
Misses 12 12 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, just one comment
def data_func(request): | ||
"""Return server side data.""" | ||
# defining columns | ||
columns = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think we should add something on aggregated columns and searchability here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I re-reran the pypy case on travis (it failed before), now it passed.
I'll keep it open until I think of a better way |
Fixes #93