Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an example that returns a sum of values. #94

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Pegase745
Copy link
Owner

Fixes #93

@Pegase745 Pegase745 self-assigned this May 4, 2017
@Pegase745 Pegase745 requested a review from tdamsma May 4, 2017 11:08
Copy link

@saifraider saifraider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It helped a lot.

@codecov-io
Copy link

codecov-io commented May 4, 2017

Codecov Report

Merging #94 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #94   +/-   ##
=======================================
  Coverage   93.68%   93.68%           
=======================================
  Files           1        1           
  Lines         190      190           
=======================================
  Hits          178      178           
  Misses         12       12

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1068c2...5daa58a. Read the comment docs.

Copy link
Collaborator

@tdamsma tdamsma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, just one comment

def data_func(request):
"""Return server side data."""
# defining columns
columns = [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think we should add something on aggregated columns and searchability here

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I re-reran the pypy case on travis (it failed before), now it passed.

@Pegase745
Copy link
Owner Author

I'll keep it open until I think of a better way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants