Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update http crate dependency #537

Merged
merged 1 commit into from
Jul 21, 2023
Merged

Conversation

cbrit
Copy link
Member

@cbrit cbrit commented Jul 20, 2023

Steward is breaking in dev when I pull in a version of somm_proto that includes the pubsub bindings in the axelar-v2 branch. This is happening despite the fact that there is no diff between the lock files on main and axelar-v2:

error: failed to select a version for `http`.
    ... required by package `axum v0.6.9`
    ... which satisfies dependency `axum = "^0.6.9"` of package `tonic v0.9.0`
    ... which satisfies dependency `tonic = "^0.9"` of package `cosmos-sdk-proto v0.19.0 (http://github.com/cosmos/cosmos-rust?branch=main#aef5c708)`
    ... which satisfies git dependency `cosmos-sdk-proto` of package `somm_proto v5.0.0 (https://github.com/peggyjv/sommelier?branch=axelar-v2#fe273124)`
    ... which satisfies git dependency `somm_proto` of package `steward v3.0.0 (/Users/atro/source/work/steward)`
versions that meet the requirements `^0.2.9` are: 0.2.9

all possible versions conflict with previously selected packages.

  previously selected package `http v0.2.8`
    ... which satisfies dependency `http = "^0.2.0"` (locked to 0.2.8) of package `actix-connect v2.0.0`
    ... which satisfies dependency `actix-connect = "^2.0.0"` (locked to 2.0.0) of package `actix-http v2.2.2`
    ... which satisfies dependency `actix-http = "^2.2.0"` (locked to 2.2.2) of package `actix-web v3.3.3`
    ... which satisfies dependency `actix-web = "^3"` (locked to 3.3.3) of package `contact v0.4.2`
    ... which satisfies dependency `contact = "^0.4"` (locked to 0.4.2) of package `register_delegate_keys v2.0.0 (https://github.com/PeggyJV/gravity-bridge?branch=main#7ce6b3c1)`
    ... which satisfies git dependency `register_delegate_keys` (locked to 2.0.0) of package `gravity_bridge v2.0.4 (https://github.com/PeggyJV/gravity-bridge?branch=main#7ce6b3c1)`
    ... which satisfies git dependency `gravity_bridge` (locked to 2.0.4) of package `steward v3.0.0 (/Users/atro/source/work/steward)`

failed to select a version for `http` which could resolve this conflict

I've made this change locally so I can continue development, but wanted to go ahead and make a PR to reflect the change.

@cbrit cbrit requested a review from EricBolten July 20, 2023 19:24
@cbrit cbrit temporarily deployed to CI July 20, 2023 19:46 — with GitHub Actions Inactive
@cbrit cbrit temporarily deployed to CI July 20, 2023 19:46 — with GitHub Actions Inactive
@cbrit cbrit temporarily deployed to CI July 20, 2023 19:46 — with GitHub Actions Inactive
@cbrit cbrit temporarily deployed to CI July 20, 2023 19:46 — with GitHub Actions Inactive
Copy link
Contributor

@EricBolten EricBolten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EricBolten EricBolten merged commit 817fe21 into main Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants