Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consensus version 3 upgrade/migration #541

Merged
merged 12 commits into from
Aug 18, 2023
Merged

Consensus version 3 upgrade/migration #541

merged 12 commits into from
Aug 18, 2023

Conversation

cbrit
Copy link
Member

@cbrit cbrit commented Aug 14, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2023 •
edited
Loading

Codecov Report

Merging #541 (bacb5a6) into main (76006da) will decrease coverage by 0.08%.
The diff coverage is 0.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #541      +/-   ##
==========================================
- Coverage   30.01%   29.93%   -0.08%     
==========================================
  Files          48       49       +1     
  Lines        6987     7005      +18     
==========================================
  Hits         2097     2097              
- Misses       4708     4726      +18     
  Partials      182      182
Files Changed Coverage Δ
module/app/app.go 0.58% <0.00%> (-0.01%) ⬇️
module/app/upgrades/v3/upgrades.go 0.00% <0.00%> (ø)
module/x/gravity/keeper/migrations.go 0.00% <0.00%> (ø)
module/x/gravity/module.go 2.53% <0.00%> (-0.07%) ⬇️

@cbrit cbrit temporarily deployed to CI August 14, 2023 19:10 — with GitHub Actions Inactive
@cbrit cbrit temporarily deployed to CI August 14, 2023 19:10 — with GitHub Actions Inactive
@cbrit cbrit temporarily deployed to CI August 14, 2023 19:10 — with GitHub Actions Inactive
EricBolten
EricBolten reviewed Aug 15, 2023
View reviewed changes
Copy link
Contributor

@EricBolten EricBolten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some feedback.

module/app/upgrades/v3/README.md Show resolved Hide resolved
module/app/upgrades/v3/constants.go Outdated Show resolved Hide resolved
module/app/upgrades/v3/upgrades.go Outdated Show resolved Hide resolved
module/x/gravity/migrations/v2/store.go Outdated Show resolved Hide resolved
module/x/gravity/migrations/v2/keys.go Outdated Show resolved Hide resolved
module/app/app.go Show resolved Hide resolved
@cbrit cbrit temporarily deployed to CI August 15, 2023 15:27 — with GitHub Actions Inactive
@cbrit cbrit temporarily deployed to CI August 15, 2023 15:27 — with GitHub Actions Inactive
@cbrit cbrit temporarily deployed to CI August 15, 2023 15:27 — with GitHub Actions Inactive
@cbrit cbrit temporarily deployed to CI August 15, 2023 15:27 — with GitHub Actions Inactive
@cbrit cbrit temporarily deployed to CI August 17, 2023 20:08 — with GitHub Actions Inactive
@cbrit cbrit temporarily deployed to CI August 17, 2023 20:08 — with GitHub Actions Inactive
@cbrit cbrit temporarily deployed to CI August 17, 2023 20:18 — with GitHub Actions Inactive
@cbrit cbrit temporarily deployed to CI August 17, 2023 20:18 — with GitHub Actions Inactive
@cbrit cbrit temporarily deployed to CI August 17, 2023 20:18 — with GitHub Actions Inactive
@cbrit cbrit temporarily deployed to CI August 17, 2023 20:18 — with GitHub Actions Inactive
@cbrit cbrit temporarily deployed to CI August 17, 2023 21:21 — with GitHub Actions Inactive
@cbrit cbrit temporarily deployed to CI August 17, 2023 21:21 — with GitHub Actions Inactive
@cbrit cbrit temporarily deployed to CI August 17, 2023 21:21 — with GitHub Actions Inactive
@cbrit cbrit temporarily deployed to CI August 17, 2023 21:21 — with GitHub Actions Inactive
EricBolten
EricBolten reviewed Aug 17, 2023
View reviewed changes
Copy link
Contributor

@EricBolten EricBolten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few last comments.

module/x/gravity/migrations/v2/store.go Outdated Show resolved Hide resolved
module/x/gravity/module.go Outdated Show resolved Hide resolved
@cbrit cbrit temporarily deployed to CI August 18, 2023 14:36 — with GitHub Actions Inactive
@cbrit cbrit temporarily deployed to CI August 18, 2023 14:36 — with GitHub Actions Inactive
@cbrit cbrit temporarily deployed to CI August 18, 2023 14:51 — with GitHub Actions Inactive
@cbrit cbrit temporarily deployed to CI August 18, 2023 14:51 — with GitHub Actions Inactive
@cbrit cbrit temporarily deployed to CI August 18, 2023 14:51 — with GitHub Actions Inactive
@cbrit cbrit temporarily deployed to CI August 18, 2023 14:51 — with GitHub Actions Inactive
EricBolten
EricBolten approved these changes Aug 18, 2023
View reviewed changes
Copy link
Contributor

@EricBolten EricBolten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EricBolten EricBolten merged commit 143c0cb into main Aug 18, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EricBolten EricBolten EricBolten approved these changes

@zmanian zmanian Awaiting requested review from zmanian

@jackzampolin jackzampolin Awaiting requested review from jackzampolin

@mvid mvid Awaiting requested review from mvid

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cbrit @codecov-commenter @EricBolten