Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a linter to check typos in non-Go files #1183

Open
haoming29 opened this issue Apr 26, 2024 · 0 comments · May be fixed by #1798
Open

Add a linter to check typos in non-Go files #1183

haoming29 opened this issue Apr 26, 2024 · 0 comments · May be fixed by #1798
Assignees
@brianaydemir
Labels
good first issue Good for newcomers internal Internal code improvements, not user-facing
Milestone
v7.13.0

Comments

@haoming29
Copy link
Contributor

We added a linter to golang-ci to check typos in Go source code #1159, It would be beneficial if we do the same check for files outside of Go, like docs.

There seems to be one actively maintained tool that supports pre-commit integration for typo check: https://github.com/crate-ci/typos
@haoming29 haoming29 added the internal Internal code improvements, not user-facing label Apr 26, 2024
@haoming29 haoming29 added the good first issue Good for newcomers label May 20, 2024
@brianaydemir brianaydemir self-assigned this Dec 5, 2024
@brianaydemir brianaydemir linked a pull request Dec 5, 2024 that will close this issue
Run additional linters as pre-commit hooks #1798
Open
@brianaydemir brianaydemir linked a pull request Dec 6, 2024 that will close this issue
Open
@brianaydemir brianaydemir added this to the v7.13.0 milestone Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brianaydemir brianaydemir

Labels
good first issue Good for newcomers internal Internal code improvements, not user-facing
Projects
None yet
Milestone
v7.13.0
Development

Successfully merging a pull request may close this issue.

Run additional linters as pre-commit hooks brianaydemir/pelicanplatform-pelican
2 participants
@brianaydemir @haoming29