Run additional linters as pre-commit hooks #1798
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jhiemstrawisc Assigning to you to find a reviewer. (I'll rebase this once 7.12 is out the door.) |
jhiemstrawisc
approved these changes
Dec 16, 2024
There was a problem hiding this comment.
Since this is a critical section of bash scripting that goes beyond testing, can you double check the changes to make sure we think they're okay?
| @@ -358,7 +358,7 @@ func TestHandlePacket(t *testing.T) { | |||
| expectedLinkConnectIncDup := strings.NewReader(mockPromLinkConnectInc) | |||
| expectedLinkByteXferIncDup := strings.NewReader(mockPromLinkByteXferInc) | |||
|
|
|||
| // First time received a summmary packet | |||
There was a problem hiding this comment.
And here I had assumed this was just an extra tasty packet!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Despite the original motivation for #1183, it turns out that most of the changes in this PR are to Go files. Also, while I'm here, I decided to add ShellCheck as another linter.
My intent behind the new configuration in
.pre-commit-config.yamland_typos.yamlis to reduce the amount of code that needs "fixing" in this PR. Developers are always welcome to runtyposandshellcheckon their own, but given that this is an existing codebase, I don't think it's useful to flag every potential issue.Note that
typosdoes not run a spell check but instead has a built-in database of common spelling corrections. As a result, there might still be spelling mistakes in the code base. Furthermore, while I've applied the changes suggested bytypos, I didn't put much effort into reviewing every modified comment for clarity and grammar.I did confirm that
typosseems to be willing to run on the vast majority of relevant files in this repository.For reviewers:
images/entrypoint.shthat I'm guessing has never been used in the wild.