Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InitConfig refactor to fix initConfigDir and proper InitServer/InitClient testing. #1836

Open
turetske opened this issue Dec 17, 2024 · 0 comments
Open

InitConfig refactor to fix initConfigDir and proper InitServer/InitClient testing. #1836

turetske opened this issue Dec 17, 2024 · 0 comments
Assignees
@turetske
Labels
bug Something isn't working internal Internal code improvements, not user-facing
Milestone
v7.14

Comments

@turetske
Copy link
Collaborator

Refactor and move the InitConfig vs the InitConfigDir:

In order to fix things with the ordering of InitConfig and InitConfigDir:

  • Move InitConfig out of the root execution and into InitClient and InitServer
  • Make InitConfigDir to be private (initConfigDir)
  • Change all the tests which use InitConfigDir to use InitServer or InitClient as needed
  • Potentially refactor/rework the config_printer
  • Ensure that InitConfigDir is platform agnostic (currently seems to have Linux paths)
@turetske turetske self-assigned this Dec 17, 2024
@turetske turetske added bug Something isn't working internal Internal code improvements, not user-facing labels Dec 17, 2024
@turetske turetske mentioned this issue Dec 17, 2024
Open
@turetske turetske added this to the v7.14 milestone Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turetske turetske

Labels
bug Something isn't working internal Internal code improvements, not user-facing
Projects
None yet
Milestone
v7.14
Development

No branches or pull requests
1 participant
@turetske