-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Prometheus doc to introduce counting server number #1009
Update Prometheus doc to introduce counting server number #1009
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM just a few spelling/grammar changes
docs/pages/prometheus.mdx
Outdated
@@ -161,7 +161,7 @@ All of the Pelican servers have the following metrics: | |||
|
|||
### `up` | |||
|
|||
Although a Prometheus built-in metric, Pelican uses this metric to record number of origin/cache servers in the federation, as Pelican director scrape all the storage servers in the federation and get their Promtheus metrics. | |||
Pelican director scraps Prometheus metrics from all origins and cache servers that successfully advertised to the director. This metric reflects the Pelican origin or cache servers that are scraped by the director. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
scraps --> scrapes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably also want "The Pelican director" instead of just "Pelican director"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace "advertised" with "advertise"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Once tests pass feel free to merge
Closes #1006