Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Prometheus doc to introduce counting server number #1009

Merged
merged 2 commits into from
Apr 1, 2024

Conversation

haoming29
Copy link
Contributor

Closes #1006

@haoming29 haoming29 added the documentation Improvements or additions to documentation label Mar 28, 2024
@haoming29 haoming29 requested a review from joereuss12 March 28, 2024 21:44
Copy link
Contributor

@joereuss12 joereuss12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just a few spelling/grammar changes

@@ -161,7 +161,7 @@ All of the Pelican servers have the following metrics:

### `up`

Although a Prometheus built-in metric, Pelican uses this metric to record number of origin/cache servers in the federation, as Pelican director scrape all the storage servers in the federation and get their Promtheus metrics.
Pelican director scraps Prometheus metrics from all origins and cache servers that successfully advertised to the director. This metric reflects the Pelican origin or cache servers that are scraped by the director.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scraps --> scrapes?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably also want "The Pelican director" instead of just "Pelican director"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace "advertised" with "advertise"

@haoming29 haoming29 requested a review from joereuss12 April 1, 2024 18:08
Copy link
Contributor

@joereuss12 joereuss12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Once tests pass feel free to merge

@haoming29 haoming29 merged commit dbc2dd5 into PelicanPlatform:main Apr 1, 2024
19 checks passed
@haoming29 haoming29 deleted the update-metric-doc-count branch April 1, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add instruction in Prometheus documentation on how to count number of servers in the federation
2 participants