Add "login required" endpoints behind "admin" check and fix bug in admin auth handler #1013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Also fixed a bug where admin auth handler didn't abort at check failure
haoming29
added
bug
|
Is there any hand test I should run for this to make sure things are working as expected? |
Try Another endpoint to check is the |
jhiemstrawisc
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1004
This PR also fix a bug in admin auth handler where if the user is not a admin, the handler didn't abort the request, causing the response to pass.
This is a critical bug with security concern and we should consider backport to 7.6 and 7.5.
Improved testing to cover both cases.