-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GZIP web responses #1458
base: main
Are you sure you want to change the base?
GZIP web responses #1458
Conversation
8.2mb to 1.8mb
Going to keep this as a draft as I test to make sure that this doesn't break any endpoints. |
8.2mb to 1.8mb
@haoming29 This is ready, but it will cause issues on any endpoints that already gzip such as the prometheus endpoints as it will double zip them. Can you think of any endpoints other the prometheus that we don't produce? I can also limit it to only zip web assets. |
I can't think of any other endpoints that we import as as a whole (like Prometheus), which means we should be able to control the compression for all of the rest. Would gzip affect attachment though? We do have some endpoints that have |
@CannonLock looks like there's a unhandled merge conflict that causes tests to fail |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One other endpoint that need to be excluded; otherwise LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to me, but can you rebase/deal with the merge conflicts before I approve?
@turetske What merge conflicts? |
Ah, my bad, I was misinterpreting the test failures. Hopefully they are just intermittent failures. |
@CannonLock The broker tests keep having a timeout. Could adding the gzip like this potentially slow down a callback to be beyond our threshold? (10 minutes)? |
I noticed this PR is creeping on 5 months since it was opened and 4 months since it was last updated. Is it something that we plan on picking back up? |
@jhiemstrawisc I can close and reopen in the future when complete? This is a small upgrade that looks like it is going to take more time then it is worth to fix so it isn't high on my priority list. |
I think we can get away just marking it as a draft if you eventually plan on returning to it |
8.2mb to 1.8mb