-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uniform error handling #1687
Uniform error handling #1687
Conversation
Allows us to have more consistent styles with this code and the other code that we write that is compiled for js consumption. If we need a .d.ts file we can let the compiler create it.
- Move registry pages behind auth check - Create get.ts which holds api endpoints that get updated - Fix AuthenticatedContent.tsx to check it auth value is true
Had to close another issue when implementing the auth'd registry pages. Closes #1728 |
There's a failed Ubuntu test, could you take a second look when you have a chance |
@h2zh Do you have any insights into the failure? This is a UI only change so it shouldn't effect any of the pelican tests unless the web build itself failed which I know isn't the case. |
@CannonLock, this is a known bad test at this point. If the failing |
Couple things that will make this a better path forward.
Closes #1582