Add a refresh interval to the origin exports #1792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- UI and UI backing updates to make sure its up to date
Screen.Recording.2024-12-03.at.3.52.09.PM.mov |
|
Closes #1520 |
|
This loading bar pops up every time when the origin page reloads. Is that an expected behavior? |
Only indicate loading if returning from registry
Tweak language and header updates
- Toss component in Suspense boundary
|
@h2zh I didn't think to remove it all the time. I pushed a couple commits to address this. Now it knows when it is being returned to from the registry and will only poll/show the loading bar then. |
h2zh
reviewed
Dec 12, 2024
CannonLock
commented
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current issue is that when you redirect from a corrected registration in the registry back to the origin you were registering the initial query from the origin is so fast that it misses the changes.
This adds a UI loading bar that waits 5 seconds for a requery. If for some reason it takes longer then 5 seconds I also auto refresh these metrics every 5 seconds in the background so things will just switch over automatically in the UI.