Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make website mobile friendly #1815

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Make website mobile friendly #1815

wants to merge 11 commits into from

Conversation

CannonLock
Copy link
Contributor

@CannonLock CannonLock commented Dec 9, 2024 •
edited
Loading

  • Added global navigation config
  • Created Navigation Component to consume config
  • Added AppBar for mobile
  • Made all components mobile friendly

Features:

  • Configuration and future shared pages will use server navigation if only one server is active
  • Canonicalized showing navigation based on authorization level and export type. Easy to add future updates.

@CannonLock
Update Existing Navigation
0ae9ead 
- Added global config
- Created Navigation Component to consume config

Features:
- Configuration and future shared pages will use server navigation if only one server is active
- Canonicalized showing navigation based on authorization level and export type. Easy to add future updates.
@CannonLock
Copy link
Contributor Author

Closes #1679

@CannonLock CannonLock linked an issue Dec 9, 2024 that may be closed by this pull request
Mobile Friendly Webapp #1679
Open
2 tasks
@CannonLock
Copy link
Contributor Author

1781

@CannonLock CannonLock marked this pull request as ready for review December 12, 2024 19:18
@CannonLock
Copy link
Contributor Author

Screen.Recording.2024-12-12.at.1.16.18.PM.mov

@CannonLock CannonLock added enhancement New feature or request javascript Pull requests that update Javascript code origin Issue relating to the origin component registry Issue relating to the registry component web-ui Related to our web displays labels Dec 16, 2024
@CannonLock CannonLock requested a review from h2zh December 16, 2024 19:38
@h2zh
Copy link
Collaborator

h2zh commented Dec 18, 2024

Why do so many tests hold a different opinion this time...

@CannonLock
Copy link
Contributor Author

No idea, my stuff is UI only and these are not UI failures.

@CannonLock CannonLock added this to the v7.13.0 milestone Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h2zh h2zh Awaiting requested review from h2zh

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
enhancement New feature or request javascript Pull requests that update Javascript code origin Issue relating to the origin component registry Issue relating to the registry component web-ui Related to our web displays
Projects
None yet
Milestone
v7.13.0
Development

Successfully merging this pull request may close these issues.

Mobile Friendly Webapp
2 participants
@CannonLock @h2zh