Implement Object Delete Command #1816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhiemstrawisc
requested changes
Dec 11, 2024
Saartank
added
enhancement
…ector matchmaking
jhiemstrawisc
requested changes
Dec 18, 2024
client/fed_linux_test.go
Outdated
|
|
||
| // Note: Even though os.Mkdir is called with permissions, it may create directories | ||
| // with 0755 permissions due to internal behavior. To ensure the directory has the desired | ||
| // permissions permissions, we explicitly call os.Chmod after creating the directory. |
There was a problem hiding this comment.
Still one extra "permissions" here
jhiemstrawisc
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #1685 by implementing an object delete command.
The object delete command is not openly supported and is marked hidden. It deletes data from the origin and does not clean data from caches the data might have propagated to.
The object delete command supports the recursive option to delete collections.