Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed 'pelican://' checking in _check_fspath #55

Merged
merged 4 commits into from
Dec 3, 2024

Conversation

turetske
Copy link
Collaborator

I believe this will close #54

The previous version wasn't properly working with any urls which already had the "pelican://" scheme to it.

@bbockelm Please correct this if I misinterpreted what the function was supposed to do.

@turetske turetske requested a review from bbockelm May 27, 2024 18:43
Copy link
Member

@jhiemstrawisc jhiemstrawisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems okay, but I haven't done any rigorous testing.

@turetske turetske merged commit 87f5949 into PelicanPlatform:main Dec 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix _check_fspath to fully with Pelican-Style-URLS
2 participants