trailing / messes up signing of request

PelicanPlatform · Nov 19, 2024 · 6aa4eb9 · 6aa4eb9
1 parent 72bfb9a
commit 6aa4eb9
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/S3Commands.cc b/src/S3Commands.cc
@@ -553,8 +553,8 @@ bool AmazonS3Head::SendRequest() {
 // ---------------------------------------------------------------------------
 
 bool AmazonS3List::SendRequest(const std::string &continuationToken) {
-	// query_parameters["list-type"] = "2"; // Version 2 of the object-listing
-	// API query_parameters["delimiter"] = "/";
+	query_parameters["list-type"] = "2"; // Version 2 of the object-listing
+	query_parameters["delimiter"] = "/";
 	query_parameters["prefix"] = urlquote(object);
 	query_parameters["encoding-type"] = "url";
 	if (!continuationToken.empty()) {

diff --git a/test/s3_tests.cc b/test/s3_tests.cc
@@ -49,7 +49,8 @@ TEST(TestS3URLGeneration, Test1) {
 	TestAmazonRequest pathReq{serviceUrl, "akf", "skf", b, o, "path", 4};
 	std::string generatedHostUrl = pathReq.getHostUrl();
 	ASSERT_EQ(generatedHostUrl,
-			  "https://s3-service.com:443/test-bucket/test-object");
+			  "https://s3-service.com:443/test-bucket/test-object")
+		<< "generatedURL: " << generatedHostUrl;
 
 	// Test virtual-style URL generation
 	TestAmazonRequest virtReq{serviceUrl, "akf", "skf", b, o, "virtual", 4};