Add path-style hosting to plugin #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Comment on lines
8
to
+9
| #include "S3File.hh" | ||
| #include "stl_string_utils.hh" |
There was a problem hiding this comment.
[lint] reported by reviewdog 🐶
Suggested change
| #include "S3File.hh" | |
| #include "stl_string_utils.hh" |
Comment on lines
6
to
+8
| #include "S3Directory.hh" | ||
| #include "S3File.hh" | ||
| #include "stl_string_utils.hh" |
There was a problem hiding this comment.
[lint] reported by reviewdog 🐶
Suggested change
| #include "S3Directory.hh" | |
| #include "S3File.hh" | |
| #include "stl_string_utils.hh" |
Comment on lines
98
to
100
| m_log.Emsg("Config", "s3.region not specified"); | ||
| return false; | ||
| } |
There was a problem hiding this comment.
[lint] reported by reviewdog 🐶
Suggested change
| m_log.Emsg("Config", "s3.region not specified"); | |
| return false; | |
| } | |
| if (!handle_required_config(attribute, "s3.service_url", value, | |
| this->s3_service_url)) { | |
| Config.Close(); | |
| return false; |
Comment on lines
+102
to
+107
| m_log.Emsg("Config", "s3.url_style not specified"); | ||
| return false; | ||
| } else { | ||
| // We want this to be case-insensitive. | ||
| toLower( this->s3_url_style ); | ||
| } |
There was a problem hiding this comment.
[lint] reported by reviewdog 🐶
Suggested change
| m_log.Emsg("Config", "s3.url_style not specified"); | |
| return false; | |
| } else { | |
| // We want this to be case-insensitive. | |
| toLower( this->s3_url_style ); | |
| } | |
| if (!handle_required_config(attribute, "s3.access_key_file", value, | |
| this->s3_access_key_file)) { | |
| Config.Close(); | |
| return false; |
Comment on lines
+109
to
+111
| m_log.Emsg("Config", "invalid s3.url_style specified. Must be 'virtual' or 'path'"); | ||
| return false; | ||
| } |
There was a problem hiding this comment.
[lint] reported by reviewdog 🐶
Suggested change
| m_log.Emsg("Config", "invalid s3.url_style specified. Must be 'virtual' or 'path'"); | |
| return false; | |
| } | |
| if (!handle_required_config(attribute, "s3.secret_key_file", value, | |
| this->s3_secret_key_file)) { | |
| Config.Close(); | |
| return false; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes PR #16 and adds the "window dressing" laid out in issue #10
Closes #10