Correctly handle the case with trailing slash in the service URL #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The service URL could technically contain a resource. E.g., ``` https://foo.example.com/prefix ``` or simply ``` https://foo.example.com/ ``` In this case, the code logic didn't handle bucket names correctly, generating invalid URLs for directory listings and stat's. This fixes said logic and adds some simple regression test coverage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The service URL could technically contain a resource. E.g.,
or simply
In this case, the code logic didn't handle bucket names correctly, generating invalid URLs for directory listings and stat's.
This fixes said logic and adds some simple regression test coverage.
Fixes issues with NCAR S3 origin not being able to perform HEAD requests.