Stat fix #65
Merged
Stat fix #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears the getSize method for the HEAD request was never correctly implemented. Move the HEAD header response parsing into the class and refactor `Fstat` to use it.
The prior fix for handling of empty object names (such as when you are listing the root of the bucket) depended on counting `/` characters (which may be inconsistent if the paths aren't normalized) and didn't cover the `S3FileSystem::Create` and `S3File::Open` methods. This pushes the fix into the `parsePath` method and adds unit test coverage to watch for regressions.
This tweaks the `Stat` logic so, if the object exists, we only query it one time. We still fallback to listing objects in case of a pseudo-directory. Includes unit test coverage. Fixes PelicanPlatform#63
bbockelm
approved these changes
Dec 14, 2024
There was a problem hiding this comment.
First version still had two round trips if the object existed. Refactored it to only do the second round trip if it's a pseudo-directory.
This also required reworking the AmazonS3Head implementation as its getSize method didn't actually function, also allowing a simplification for Fstat.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detects prefix collisions on directories and handles them correctly