Use case-insensitive search for ETag header #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbockelm
force-pushed
the
etag_case_insensitive
branch
2 times, most recently
from
d913fe7 to
f99ffb1
Compare
Refactors the ETag parsing to be done within the request command itself instead of in the filesystem layer. The code still needs to be replaced with proper header parsing. However, for now, we settle for switching to case-insensitive parsing and adding checks for return codes.
bbockelm
force-pushed
the
etag_case_insensitive
branch
from
f99ffb1 to
74da355
Compare
|
@rw2 - apologies, it appears I forgot to link this PR to the original issue so you may have missed the notification I posted it over the weekend. Even if you ended up going a different route for the fix itself in the meantime, I think there's value in the second commit (which provides unit test coverage for lower-case headers). |
rw2
reviewed
Dec 17, 2024
There was a problem hiding this comment.
Since we have an internal string library, I'd be happier if the case insensitive string compare was pulled out of here and put into the library.
rw2
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code still needs to be replaced with proper header parsing. However, for now, we settle for switching to case-insensitive parsing and adding checks for return codes.