Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write out QSIRecon pipeline-wise reports #761

Closed
wants to merge 33 commits into from

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Jun 4, 2024

Closes PennLINC/qsirecon#13.

Changes proposed in this pull request

  • Collect list of QSIRecon output directories and write out a separate HTML report to each.

@tsalo tsalo added the bug Something isn't working label Jun 4, 2024
@tsalo
Copy link
Member Author

tsalo commented Jun 4, 2024

I need to test this but I'm not sure how best to do that.

EDIT: Waiting on #763 seems to be the way to go.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Please upload report for BASE (master@87f0206). Learn more about missing BASE report.

Files Patch % Lines
qsiprep/cli/run.py 0.00% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master     PennLINC/qsiprep#761   +/-   ##
=========================================
  Coverage          ?   29.76%           
=========================================
  Files             ?       97           
  Lines             ?    14585           
  Branches          ?     1887           
=========================================
  Hits              ?     4341           
  Misses            ?    10118           
  Partials          ?      126           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsalo
Copy link
Member Author

tsalo commented Jun 25, 2024

I'm not seeing new HTML reports, so I must have messed something up.

@tsalo
Copy link
Member Author

tsalo commented Jul 9, 2024

@mattcieslak should the reconstruction pipelines be generating any figures? The reports are basically empty (minus the boilerplate that I still have to figure out).

@tsalo
Copy link
Member Author

tsalo commented Aug 14, 2024

Closing in favor of PennLINC/qsirecon#7.

@tsalo tsalo closed this Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recon reports are broken
2 participants