Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect templates from TemplateFlow instead of package data #49

Merged
merged 12 commits into from
Aug 19, 2024

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Aug 14, 2024

Closes #48.

Changes proposed in this pull request

  • Remove templates that are only used by QSIPrep.
  • Download necessary templates for TemplateFlow and reorient them to LPS with 3dResample.
  • Remove remaining templates that were used by QSIRecon.

@tsalo
Copy link
Member Author

tsalo commented Aug 14, 2024

We'll want to cache the downloaded templates in the build image so users aren't downloading them at runtime.

@tsalo tsalo added the refactor label Aug 14, 2024
@tsalo tsalo requested a review from mattcieslak August 14, 2024 13:38
@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 68.42105% with 12 lines in your changes missing coverage. Please review.

Project coverage is 33.52%. Comparing base (c80616e) to head (757df18).

Files Patch % Lines
qsirecon/interfaces/anatomical.py 72.72% 6 Missing ⚠️
qsirecon/workflows/recon/anatomical.py 0.00% 4 Missing ⚠️
qsirecon/workflows/base.py 0.00% 1 Missing ⚠️
qsirecon/workflows/reports.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #49      +/-   ##
==========================================
+ Coverage   33.42%   33.52%   +0.10%     
==========================================
  Files          56       56              
  Lines        6825     6824       -1     
  Branches      894      891       -3     
==========================================
+ Hits         2281     2288       +7     
+ Misses       4446     4438       -8     
  Partials       98       98              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsalo
Copy link
Member Author

tsalo commented Aug 14, 2024

I'm a little surprised this actually worked, since it uses AFNI's 3dResample, but I thought the only thing from AFNI that we were keeping in the Docker image was 3dAutobox?

qsirecon/interfaces/anatomical.py Outdated Show resolved Hide resolved
qsirecon/workflows/recon/anatomical.py Show resolved Hide resolved
qsirecon/workflows/recon/anatomical.py Show resolved Hide resolved
@tsalo tsalo requested a review from mattcieslak August 14, 2024 17:51
@tsalo
Copy link
Member Author

tsalo commented Aug 15, 2024

@mattcieslak does this look good to merge now?

Copy link
Contributor

@mattcieslak mattcieslak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect!

@tsalo tsalo merged commit a62147f into main Aug 19, 2024
17 checks passed
@tsalo tsalo deleted the tfl-templates branch August 19, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop internal copies of templates in favor of re-orienting TemplateFlow templates
3 participants