-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collect templates from TemplateFlow instead of package data #49
Conversation
We'll want to cache the downloaded templates in the build image so users aren't downloading them at runtime. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #49 +/- ##
==========================================
+ Coverage 33.42% 33.52% +0.10%
==========================================
Files 56 56
Lines 6825 6824 -1
Branches 894 891 -3
==========================================
+ Hits 2281 2288 +7
+ Misses 4446 4438 -8
Partials 98 98 ☔ View full report in Codecov by Sentry. |
I'm a little surprised this actually worked, since it uses AFNI's 3dResample, but I thought the only thing from AFNI that we were keeping in the Docker image was 3dAutobox? |
Co-authored-by: Matt Cieslak <[email protected]>
@mattcieslak does this look good to merge now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks perfect!
Closes #48.
Changes proposed in this pull request