Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ruff for linting #1312

Merged
merged 16 commits into from
Nov 4, 2024
Merged

Use ruff for linting #1312

merged 16 commits into from
Nov 4, 2024

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Nov 2, 2024

Closes #1311.

Changes proposed in this pull request

  • Format code with ruff, based on settings used by fMRIPrep.

@tsalo tsalo added the maintenance Issues/PRs related to maintenance. Dependency versions, dependencies, etc. label Nov 2, 2024
Copy link

codecov bot commented Nov 2, 2024

Codecov Report

Attention: Patch coverage is 70.27687% with 365 lines in your changes missing coverage. Please review.

Project coverage is 78.90%. Comparing base (f927f34) to head (2d3d4c6).

Files with missing lines Patch % Lines
xcp_d/ingression/abcdbids.py 2.17% 45 Missing ⚠️
xcp_d/ingression/hcpya.py 2.22% 44 Missing ⚠️
xcp_d/utils/bids.py 76.43% 30 Missing and 7 partials ⚠️
xcp_d/ingression/utils.py 40.81% 29 Missing ⚠️
xcp_d/interfaces/plotting.py 62.33% 29 Missing ⚠️
xcp_d/config.py 58.73% 15 Missing and 11 partials ⚠️
xcp_d/cli/parser.py 82.14% 10 Missing and 10 partials ⚠️
xcp_d/cli/run.py 28.00% 15 Missing and 3 partials ⚠️
xcp_d/interfaces/utils.py 44.82% 16 Missing ⚠️
xcp_d/interfaces/ants.py 58.33% 6 Missing and 4 partials ⚠️
... and 19 more
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1312   +/-   ##
=======================================
  Coverage   78.90%   78.90%           
=======================================
  Files          59       59           
  Lines        7381     7382    +1     
  Branches      956      956           
=======================================
+ Hits         5824     5825    +1     
  Misses       1266     1266           
  Partials      291      291           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsalo tsalo merged commit 3c7e875 into PennLINC:main Nov 4, 2024
22 checks passed
@tsalo tsalo deleted the ruff branch November 4, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Issues/PRs related to maintenance. Dependency versions, dependencies, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch to ruff for formatting
1 participant