Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use mem_mb instead of mem_gb #1417

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Use mem_mb instead of mem_gb #1417

wants to merge 7 commits into from

Conversation

smeisler
Copy link
Contributor

Closes none, but discussion on slack channel.

Changes proposed in this pull request

Use mem_mb in command line instead of gigabytes.

More consistent with other apps, allows the slurm memory environment variable to be directly input, which is helpful for BABS.

Documentation that should be reviewed

@smeisler smeisler marked this pull request as draft March 20, 2025 15:43
@smeisler
Copy link
Contributor Author

I thought the easiest route would be to change the CLI argument and then update from mb to gb in config so everything else can stay the same.

@smeisler smeisler marked this pull request as ready for review March 20, 2025 15:47
@tsalo
Copy link
Member

tsalo commented Mar 20, 2025

It looks like fMRIPrep does it all in the CLI:

    g_perfm.add_argument(
        '--mem',
        '--mem_mb',
        '--mem-mb',
        dest='memory_gb',
        action='store',
        type=_to_gb,
        metavar='MEMORY_MB',
        help='Upper bound memory limit for fMRIPrep processes',
    )

@smeisler
Copy link
Contributor Author

Changed it to be more fmriprep-like

Copy link

codecov bot commented Mar 20, 2025

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 79.02%. Comparing base (d43d167) to head (d373ad2).

Files with missing lines Patch % Lines
xcp_d/cli/parser_utils.py 20.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1417      +/-   ##
==========================================
- Coverage   79.06%   79.02%   -0.05%     
==========================================
  Files          58       58              
  Lines        7347     7352       +5     
  Branches      970      970              
==========================================
+ Hits         5809     5810       +1     
- Misses       1256     1260       +4     
  Partials      282      282              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants