-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use mem_mb
instead of mem_gb
#1417
base: main
Are you sure you want to change the base?
Conversation
I thought the easiest route would be to change the CLI argument and then update from mb to gb in config so everything else can stay the same. |
It looks like fMRIPrep does it all in the CLI: g_perfm.add_argument(
'--mem',
'--mem_mb',
'--mem-mb',
dest='memory_gb',
action='store',
type=_to_gb,
metavar='MEMORY_MB',
help='Upper bound memory limit for fMRIPrep processes',
) |
Changed it to be more fmriprep-like |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1417 +/- ##
==========================================
- Coverage 79.06% 79.02% -0.05%
==========================================
Files 58 58
Lines 7347 7352 +5
Branches 970 970
==========================================
+ Hits 5809 5810 +1
- Misses 1256 1260 +4
Partials 282 282 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Closes none, but discussion on slack channel.
Changes proposed in this pull request
Use
mem_mb
in command line instead of gigabytes.More consistent with other apps, allows the slurm memory environment variable to be directly input, which is helpful for BABS.
Documentation that should be reviewed