Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warp fsLR surfaces to NLin6 for brainsprite #1419

Merged
merged 3 commits into from
Mar 21, 2025
Merged

Warp fsLR surfaces to NLin6 for brainsprite #1419

merged 3 commits into from
Mar 21, 2025

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Mar 21, 2025

Closes #1376.

Changes proposed in this pull request

  • Warp surfaces to NLin6 space even if they're provided in fsLR space.

@tsalo tsalo added the bug Issues noting problems and PRs fixing those problems. label Mar 21, 2025
Copy link

codecov bot commented Mar 21, 2025

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.06%. Comparing base (d43d167) to head (0f12ef6).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
xcp_d/utils/sentry.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1419      +/-   ##
==========================================
- Coverage   79.06%   79.06%   -0.01%     
==========================================
  Files          58       58              
  Lines        7347     7345       -2     
  Branches      970      969       -1     
==========================================
- Hits         5809     5807       -2     
  Misses       1256     1256              
  Partials      282      282              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tsalo tsalo merged commit d00be07 into main Mar 21, 2025
24 checks passed
@tsalo tsalo deleted the warp-if-fslr branch March 21, 2025 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues noting problems and PRs fixing those problems.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test init_brainsprite_figures_wf on fsLR-space surfaces
1 participant