Add device_vjp validation #6755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albi3ro
commented
Jan 3, 2025
albi3ro
commented
Jan 3, 2025
albi3ro
commented
Jan 3, 2025
albi3ro
commented
Jan 3, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v0.40.0-rc0 #6755 +/- ##
==============================================
Coverage ? 99.60%
==============================================
Files ? 476
Lines ? 45232
Branches ? 0
==============================================
Hits ? 45055
Misses ? 177
Partials ? 0 ☔ View full report in Codecov by Sentry. |
astralcai
approved these changes
Jan 6, 2025
albi3ro
commented
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
We weren't actually validating that the
device_vjp=Truewas supported. This allowed strange circumstances where you would havedevice_vjp=True, but not support device derivatives at all, and this could lead to incorrect answers.Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues:
[sc-81479]