Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QA PRs checking process for PL 0.40 during feature freeze #6775

Merged
merged 21 commits into from
Jan 9, 2025
Merged

QA PRs checking process for PL 0.40 during feature freeze #6775

merged 21 commits into from
Jan 9, 2025

Conversation

PietropaoloFrisoni
Copy link
Contributor

As the title says.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 7, 2025

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@PietropaoloFrisoni PietropaoloFrisoni changed the title QA PR process for PL 0.40 during feature freeze QA PRs checking process for PL 0.40 during feature freeze Jan 7, 2025
@PietropaoloFrisoni PietropaoloFrisoni added this to the v0.40 milestone Jan 8, 2025
@PietropaoloFrisoni PietropaoloFrisoni marked this pull request as ready for review January 9, 2025 02:21
@codecov Codecov
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (v0.40.0-docs@e1c6b59). Learn more about missing BASE report.

Additional details and impacted files 
@@               Coverage Diff               @@
##             v0.40.0-docs    #6775   +/-   ##
===============================================
  Coverage                ?   99.60%           
===============================================
  Files                   ?      476           
  Lines                   ?    45246           
  Branches                ?        0           
===============================================
  Hits                    ?    45069           
  Misses                  ?      177           
  Partials                ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

andrijapau
andrijapau approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@andrijapau andrijapau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've got a keen eye for detail 🔎 🚀

doc/development/deprecations.rst Show resolved Hide resolved
doc/releases/changelog-0.40.0.md Outdated Show resolved Hide resolved
@JerryChen97 JerryChen97 self-requested a review January 9, 2025 14:25
JerryChen97
JerryChen97 reviewed Jan 9, 2025
View reviewed changes
Copy link
Contributor

@JerryChen97 JerryChen97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont have much to add here just curious about this circuit drawing output😂feels like I missed out a lot recent updates

pennylane/capture/base_interpreter.py Outdated Show resolved Hide resolved
JerryChen97
JerryChen97 requested changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@JerryChen97 JerryChen97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My last round of comments! Thanks a lot~

pennylane/capture/base_interpreter.py Show resolved Hide resolved
pennylane/devices/capabilities.py Show resolved Hide resolved
pennylane/capture/base_interpreter.py Outdated Show resolved Hide resolved
mudit2812
mudit2812 reviewed Jan 9, 2025
View reviewed changes
Copy link
Contributor

@mudit2812 mudit2812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed that the rendered docs for PlxprInterpreter looks like this. This should be fixed.
image

@PietropaoloFrisoni PietropaoloFrisoni enabled auto-merge (squash) January 9, 2025 22:15
@PietropaoloFrisoni PietropaoloFrisoni merged commit 670836c into v0.40.0-docs Jan 9, 2025
8 checks passed
@PietropaoloFrisoni PietropaoloFrisoni deleted the QA_PL_040_docs_PIetro branch January 9, 2025 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mudit2812 mudit2812 mudit2812 left review comments

@andrijapau andrijapau andrijapau approved these changes

@JerryChen97 JerryChen97 JerryChen97 approved these changes

@albi3ro albi3ro albi3ro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.40
Development

Successfully merging this pull request may close these issues.
5 participants
@PietropaoloFrisoni @albi3ro @mudit2812 @JerryChen97 @andrijapau