-
Notifications
You must be signed in to change notification settings - Fork 617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tape_expand.py
documentation examples
#6812
Conversation
Hello. You may have forgotten to update the changelog!
|
tape_expand.py
documentation examples
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6812 +/- ##
=======================================
Coverage 99.60% 99.60%
=======================================
Files 476 476
Lines 45215 45167 -48
=======================================
- Hits 45035 44988 -47
+ Misses 180 179 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The modifications look good to me. However, shall we add some information in description to indicate that the changes made here would not be reflected to the rendered docs? since it seems that some of the methods involved here, e.g. create_decomp_expand_fn
, have been totally invisible since the latest
at the current point. (check via: https://pennylane.ai/search?contentType=DOC&q=create_decomp_expand_fn&version=latest
)
It might be helpful as well if we can quickly check which user-faced API's call these functionalities here, and make sure no more adjustments are needed there. If it turns out to be a totally internal change which does not require further mods we might also want to mention in the PR description.
Fixes some out-of-date doc string examples that were found.
Only the
set_decomposition
docstring is user facing, but it is good to keep internal doc strings up to date as well.