Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove qtape/tape property from QNode #6825

Merged
merged 9 commits into from
Jan 15, 2025
Merged

Remove qtape/tape property from QNode #6825

merged 9 commits into from
Jan 15, 2025

Conversation

andrijapau
Copy link
Contributor

@andrijapau andrijapau commented Jan 14, 2025

Completing the deprecation cycle.

No idea why those tests didn't complain in CI before when it was first deprecated ... weird!

[sc-82149]

This comment was marked as off-topic.

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.60%. Comparing base (0bed5e8) to head (a591c70).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6825      +/-   ##
==========================================
- Coverage   99.60%   99.60%   -0.01%     
==========================================
  Files         476      476              
  Lines       45178    45169       -9     
==========================================
- Hits        44999    44990       -9     
  Misses        179      179              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrijapau andrijapau added the merge-ready ✔️ All tests pass and the PR is ready to be merged. label Jan 15, 2025
@andrijapau andrijapau enabled auto-merge (squash) January 15, 2025 21:52
@andrijapau andrijapau merged commit d90d539 into master Jan 15, 2025
45 checks passed
@andrijapau andrijapau deleted the rmv-tape-property branch January 15, 2025 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-ready ✔️ All tests pass and the PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants