gradient_kwargs is now a positional keyword argument to QNode
#6828
+51
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
andrijapau
changed the title
gradient_kwargs to QNodegradient_kwargs is now a positional keyword argument to QNode
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6828 +/- ##
=======================================
Coverage 99.60% 99.60%
=======================================
Files 476 476
Lines 45237 45240 +3
=======================================
+ Hits 45060 45063 +3
Misses 177 177 ☔ View full report in Codecov by Sentry. |
albi3ro
reviewed
Jan 14, 2025
Comment on lines
+165
to
+167
| @qml.qnode( | ||
| qml.device("default.qubit"), gradient_kwargs={"expansion_strategy": "device"} | ||
| ) |
There was a problem hiding this comment.
expansion_strategy was never a gradient keyword arg, but is a removed QNode arg.
There was a problem hiding this comment.
Ah. So do we still want to continue supporting these warnings?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
This PR could have wide-spread impact.
Pennylane Source Code
Pennylane Documentation
Catalyst
Lightning
QML Demos
Plugins
Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues:
[sc-81531]