Remove input arg control wires of multi controlled x
#6832
+15
−109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6832 +/- ##
==========================================
- Coverage 99.60% 99.60% -0.01%
==========================================
Files 476 476
Lines 45178 45172 -6
==========================================
- Hits 44999 44993 -6
Misses 179 179 ☔ View full report in Codecov by Sentry. |
JerryChen97
changed the title
control wires of multi controlled xcontrol wires of multi controlled x
JerryChen97
changed the title
control wires of multi controlled xcontrol wires of multi controlled x
astralcai
approved these changes
Jan 15, 2025
Co-authored-by: lillian542 <[email protected]>
JerryChen97
commented
Jan 15, 2025
| @@ -73,6 +73,11 @@ for details on how to port your legacy code to the new system. The following fun | |||
| Completed deprecation cycles | |||
| ---------------------------- | |||
|
|
|||
| * The input argument ``control_wires`` of ``MultiControlledX`` has been removed. | |||
|
|
|||
| - Deprecated in v0.22 | |||
There was a problem hiding this comment.
Note: we got the version info via private communication offline. Anyways it's a super far back time so don't worry too much about the accuracy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Years ago we deprecated some features inside
MultiControlledXbut they were forgotten for a while, among which we have the argumentcontrol_wiresto remove today.Description of the Change:
Remove the input
control_wiresalong with testsBenefits:
Possible Drawbacks:
Related GitHub Issues:
[sc-81795]