PhaseShift optimizations for qml.clifford_t_decomposition
#6842
+40
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6842 +/- ##
=======================================
Coverage 99.60% 99.60%
=======================================
Files 476 476
Lines 45178 45189 +11
=======================================
+ Hits 44999 45010 +11
Misses 179 179 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: Compilation transform converts adjoints of some gates to rotations that may result in complex decomposition due to the internal handling of the global phase.
Description of the Change: We try to catch
PhaseShift-based simplification when we process rotation gates.Benefits: Some simple cases like Adjoint(S) and Adjoint(T) will no longer give unexpectedly deep decompositions.
Possible Drawbacks:
Related GitHub Issues: [sc-82010], #6131