-
Notifications
You must be signed in to change notification settings - Fork 621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deprecations that weren't caught by CI #6879
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6879 +/- ##
==========================================
- Coverage 99.54% 99.54% -0.01%
==========================================
Files 477 477
Lines 45251 45246 -5
==========================================
- Hits 45047 45042 -5
Misses 204 204 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to go back and check the git history to see what this code actually needs to do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that I've fixed the riemannian gradient optimizer in #6882, but that might take a little longer to get in than this one.
Now I kinda want to go fix qnspsa 😬
**Context:** When reviewing #6879 , I noticed some usage of deprecated behaviour in `RiemannianGradientOptimizer`. So I have now fixed it. **Description of the Change:** Some minor reworking of `RiemannianGradientOptimizer` to take advantage of features pennylane now provides. **Benefits:** Enhanced readability, maintainability, and performance. **Possible Drawbacks:** **Related GitHub Issues:**
Context:
PR #6822 deprecated the arguments
config
andinner_transform_program
toqml.execute
. However, because of some bug in our CI, theqml.PennyLaneDeprecationWarning
are not being treated as errors. I just happened to find this warning in our CI logs.Description of the Change:
Promoted
qml.PennyLaneDeprecationWarning
to aValueError
to fish out any deprecated code. Updated said code to useqml.workflow.run
instead ofqml.execute
.[sc-81529]