Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Make qml.FlipSign jittable #7127

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

[WIP] Make qml.FlipSign jittable #7127

wants to merge 3 commits into from

Conversation

andrijapau
Copy link
Contributor

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    test directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the doc/releases/changelog-dev.md file, summarizing the
    change, and including a link back to the PR.

  • The PennyLane source code conforms to
    PEP8 standards.
    We check all of our code against Pylint.
    To lint modified files, simply pip install pylint, and then
    run pylint pennylane/path/to/file.py.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@andrijapau andrijapau added the WIP 🚧 Work-in-progress label Mar 20, 2025
@andrijapau andrijapau marked this pull request as draft March 20, 2025 19:09
@joeycarter
Copy link
Contributor

For wider visibility, we have an issue open for this in Catalyst: PennyLaneAI/catalyst#1265. So once this PR is merged we should be able to close it 🥳

@andrijapau
Copy link
Contributor Author

For wider visibility, we have an issue open for this in Catalyst: PennyLaneAI/catalyst#1265. So once this PR is merged we should be able to close it 🥳

Hey @joeycarter, this PR is not being prioritized at the moment. And has a decent amount of work required to get it working lol. The pain point comes from the next step being making control_values jittable 😢 .

@andrijapau andrijapau changed the title Make qml.FlipSign jittable [WIP] Make qml.FlipSign jittable Apr 1, 2025
@joeycarter
Copy link
Contributor

For wider visibility, we have an issue open for this in Catalyst: PennyLaneAI/catalyst#1265. So once this PR is merged we should be able to close it 🥳

Hey @joeycarter, this PR is not being prioritized at the moment. And has a decent amount of work required to get it working lol. The pain point comes from the next step being making control_values jittable 😢 .

No worries! It's not high priority for Catalyst either. I just saw that the PR is open so wanted to link it to the corresponding issue in Catalyst 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP 🚧 Work-in-progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants